Security Issue: Buffer Overflow Risk

There's a potential buffer overflow vulnerability in this change. The original code had a safety constraint with .min(8) that limited the number of bytes copied to the size of the padded array:

let len = bytes.len().min(8);

This constraint has been removed in the new code:

let len = bytes.len();

If bytes.len() exceeds 8, the subsequent line padded[..len].copy_from_slice(&bytes[..len]) will attempt to copy more bytes than the padded array can hold (which is fixed at 8 bytes), resulting in a buffer overflow. This would cause either a panic at runtime or memory corruption depending on the execution context.

The original .min(8) constraint should be restored to maintain memory safety.

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

When calling delete_key_subspace() with OutboundDesiredSlotsKey::subspace(namespace_id), there's a potential issue with the subspace targeting. Please verify that this correctly deletes all keys under the namespace's outbound desired slots. The method creates a subspace for a specific namespace, but it's important to ensure the deletion logic properly targets all relevant keys to prevent data inconsistency or orphaned records. Consider adding a test case that confirms complete cleanup of these keys when switching from Outbound to Custom runner kind.

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.